feat(cli): adjust prisma init to write to .env instead of prisma/.env#4341
Closed
williamluke4 wants to merge 8 commits intomasterfrom
Closed
feat(cli): adjust prisma init to write to .env instead of prisma/.env#4341williamluke4 wants to merge 8 commits intomasterfrom
prisma init to write to .env instead of prisma/.env#4341williamluke4 wants to merge 8 commits intomasterfrom
Conversation
1abd55c to
fcc7e2a
Compare
timsuchanek
reviewed
Nov 26, 2020
timsuchanek
reviewed
Nov 26, 2020
| const envFile = fs.readFileSync(envPath, { encoding: 'utf8'}) | ||
| const config = dotenv.parse(envFile) // will return an object | ||
| if(Object.keys(config).includes("DATABASE_URL")){ | ||
| console.warn(`${chalk.yellow('warn')} DATABASE_URL already exists in ${chalk.bold(envPath)}`) |
Contributor
There was a problem hiding this comment.
Let's be more actionable here and tell users what we would have printed and what they can do
Author
There was a problem hiding this comment.
What do you mean by this? This is the information that is currently printed https://github.com/prisma/prisma/blob/williamluke4/issue3721/src/packages/cli/src/__tests__/__snapshots__/init.test.ts.snap#L49-L66
Contributor
There was a problem hiding this comment.
Something like:
To resolve this, we recommend moving the `DATABASE_URL` env var to the root .env
Author
There was a problem hiding this comment.
They don't really need to resolve anything as this is just a warning them that they already have an ENV VAR named DATABASE_URL in their root .env. Therefore we will just not add our default DATABASE_URL to it.
added 7 commits
December 1, 2020 11:03
3dadb48 to
6b89df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.