packages/client-generator-ts/tests/generator.test.ts (1)

89-144: ⚠️ Potential issue | 🟡 Minor

Ensure generator.stop() always runs with try/finally.

In Line 143 and Line 161, cleanup is on the success path only. If an assertion or file read fails, generator.stop() is skipped.

Suggested hardening

 test('minimal', async () => {
   const generator = await getGenerator({
     schemaPath: path.join(__dirname, 'schema.prisma'),
     printDownloadProgress: false,
     skipDownload: true,
     registry,
   })
-
-  const manifest = omit(generator.manifest!, ['version'])
+  try {
+    const manifest = omit(generator.manifest!, ['version'])
 
-  if (manifest.requiresEngineVersion?.length !== 40) {
-    throw new Error(`Generator manifest should have "requiresEngineVersion" with length 40`)
-  }
-  manifest.requiresEngineVersion = 'ENGINE_VERSION_TEST'
+    if (manifest.requiresEngineVersion?.length !== 40) {
+      throw new Error(`Generator manifest should have "requiresEngineVersion" with length 40`)
+    }
+    manifest.requiresEngineVersion = 'ENGINE_VERSION_TEST'
 
-  // ... assertions ...
+    // ... assertions ...
 
-  await generator.generate()
-  const clientDir = path.join(__dirname, 'generated')
-  expect(fs.existsSync(clientDir)).toBe(true)
-  expect(fs.existsSync(path.join(clientDir, 'client.ts'))).toBe(true)
-
-  generator.stop()
+    await generator.generate()
+    const clientDir = path.join(__dirname, 'generated')
+    expect(fs.existsSync(clientDir)).toBe(true)
+    expect(fs.existsSync(path.join(clientDir, 'client.ts'))).toBe(true)
+  } finally {
+    generator.stop()
+  }
 })
 
 test('emits portable typed null singleton exports in the browser namespace', async () => {
   const generator = await getGenerator({
     schemaPath: path.join(__dirname, 'schema.prisma'),
     printDownloadProgress: false,
     skipDownload: true,
     registry,
   })
-
-  await generator.generate()
-  const clientDir = path.join(__dirname, 'generated')
-  const browserNamespace = fs.readFileSync(path.join(clientDir, 'internal', 'prismaNamespaceBrowser.ts'), 'utf8')
-  expect(browserNamespace).toContain('export const DbNull: typeof runtime.DbNull = runtime.DbNull')
-  expect(browserNamespace).toContain('export const JsonNull: typeof runtime.JsonNull = runtime.JsonNull')
-  expect(browserNamespace).toContain('export const AnyNull: typeof runtime.AnyNull = runtime.AnyNull')
-
-  generator.stop()
+  try {
+    await generator.generate()
+    const clientDir = path.join(__dirname, 'generated')
+    const browserNamespace = fs.readFileSync(path.join(clientDir, 'internal', 'prismaNamespaceBrowser.ts'), 'utf8')
+    expect(browserNamespace).toContain('export const DbNull: typeof runtime.DbNull = runtime.DbNull')
+    expect(browserNamespace).toContain('export const JsonNull: typeof runtime.JsonNull = runtime.JsonNull')
+    expect(browserNamespace).toContain('export const AnyNull: typeof runtime.AnyNull = runtime.AnyNull')
+  } finally {
+    generator.stop()
+  }
 })

Also applies to: 146-162

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/client-generator-ts/tests/generator.test.ts` around lines 89 - 144,
The test should ensure generator.stop() is always called by wrapping generator
usage in a try/finally: locate the test function named "test('minimal')" (and
the other similar test around the second block) where getGenerator(...) is
awaited and generator.generate() is called, move generator.stop() into a finally
block so it runs even if assertions or file operations fail; keep generator
variable in scope (declared before try) and call generator.stop() in the finally
to guarantee cleanup.