Skip to content

fix(client): mapped enums#28880

Draft
jkomyno wants to merge 3 commits intomainfrom
fix/enums-mapped-types-v7
Draft

fix(client): mapped enums#28880
jkomyno wants to merge 3 commits intomainfrom
fix/enums-mapped-types-v7

Conversation

@jkomyno
Copy link
Copy Markdown
Contributor

@jkomyno jkomyno commented Dec 8, 2025

draft

This PR:

  • closes Mapped enums with create function seem to not work correctly #28591
  • adds a new functional test, issues/28591-mapped-enums
    • before the commits that implemented the fix, the test would fail with:
        ● typescript › issues.28591-mapped-enums.test (provider=postgresql, js_pg)/test.ts
      
          assert.fail(received, expected)
      
          Message:
            Type '"PENDING"' is not assignable to type 'SuggestionStatus | undefined'. Did you mean '"pending"'? At: tests/functional/issues/28591-mapped-enums/.generated/issues.28591-mapped-enums.test (provider=postgresql, js_pg)/test.ts:13:11
      
            70 |     for (const checkPath of keys(suiteChecks)) {
            71 |       if (checkPath.includes(path.dirname(suiteFilePath))) {
          > 72 |         assert.fail(suiteChecks[checkPath])
               |                ^
            73 |       }
            74 |     }
            75 |   })
      
            at typescript/tests.ts:72:16
      

/integration

@jkomyno jkomyno added this to the 7.2.0 milestone Dec 8, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 8, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/enums-mapped-types-v7

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 8, 2025

size-limit report 📦

Path Size
packages/client/runtime/index-browser.js 2.23 KB (0%)
packages/client/runtime/index-browser.d.ts 3.28 KB (0%)
packages/cli/build/index.js 2.51 MB (0%)
packages/client/prisma-client-0.0.0.tgz 10.24 MB (-0.01% 🔽)
packages/cli/prisma-0.0.0.tgz 6.71 MB (0%)
packages/bundle-size/da-workers-libsql/output.tgz 805.36 KB (0%)
packages/bundle-size/da-workers-neon/output.tgz 859.4 KB (0%)
packages/bundle-size/da-workers-pg/output.tgz 852.34 KB (0%)
packages/bundle-size/da-workers-planetscale/output.tgz 804.91 KB (0%)
packages/bundle-size/da-workers-d1/output.tgz 788.27 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mapped enums with create function seem to not work correctly

1 participant