fix(client): Don't rely on instanceof to detect TypedSQL instances#25453
Merged
fix(client): Don't rely on instanceof to detect TypedSQL instances#25453
instanceof to detect TypedSQL instances#25453Conversation
HMR can mess up `instanceof` checks so that older typed sql instances won't be detected by newer, hot reloaded runtime. Fixing this by adding "magic" property to the `TypedSQL` class and checking for that instead, so it works across realms/different runtime instances. Fix #25331
Contributor
size-limit report 📦
|
aqrln
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HMR can mess up
instanceofchecks so that older typed sql instanceswon't be detected by newer, hot reloaded runtime.
Fixing this by adding "magic" property to the
TypedSQLclass andchecking for that instead, so it works across realms/different runtime
instances.
Fix #25331