Skip to content

feat(cli): Add a --with-model arg to generate an example schema#21195

Merged
Jolg42 merged 8 commits intoprisma:mainfrom
Kayoshi-dev:feat/generate-an-example-schema
Apr 26, 2024
Merged

feat(cli): Add a --with-model arg to generate an example schema#21195
Jolg42 merged 8 commits intoprisma:mainfrom
Kayoshi-dev:feat/generate-an-example-schema

Conversation

@Kayoshi-dev
Copy link
Copy Markdown
Contributor

Hello! This is my first time contributing to an open source project that big!

This add a new --with-model params you can give to the CLI to generate a new project with a predefined schema containing a User model.

It should closes #20915.

Tried my best, feel free to tell me if something seems wrong!

@Kayoshi-dev Kayoshi-dev requested a review from a team as a code owner September 22, 2023 17:14
@Kayoshi-dev Kayoshi-dev requested review from Jolg42 and aqrln and removed request for a team September 22, 2023 17:14
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 22, 2023

CLA assistant check
All committers have signed the CLA.

@Kayoshi-dev Kayoshi-dev requested a review from janpio September 26, 2023 18:52
Copy link
Copy Markdown
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@janpio janpio added this to the 5.4.0 milestone Sep 28, 2023
Copy link
Copy Markdown
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you so much.

The only remaining tiny thing you could do is add a snapshot for the prisma init --help output , as you changed that but the tests did not have to change to reflect that - so we are missing that one. But I think we could also merge without it, as that is not your fault.

@janpio janpio requested a review from millsp September 28, 2023 11:25
@millsp millsp self-assigned this Oct 26, 2023
@apolanc apolanc removed this from the 5.4.0 milestone Mar 5, 2024
@apolanc apolanc added kind/feature A request for a new feature. PR: Feature A PR That introduces a new feature and removed kind/feature A request for a new feature. labels Mar 13, 2024
@Jolg42 Jolg42 self-assigned this Mar 15, 2024
@Jolg42 Jolg42 added this to the 5.14.0 milestone Apr 25, 2024
@Kayoshi-dev Kayoshi-dev requested a review from a team as a code owner April 25, 2024 16:16
@Jolg42 Jolg42 merged commit 21e923a into prisma:main Apr 26, 2024
@Jolg42
Copy link
Copy Markdown
Contributor

Jolg42 commented Apr 26, 2024

This is now available in our dev version 5.14.0-dev.21 and will be part of the next official version 5.14.0 scheduled for May, 14th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Feature A PR That introduces a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prisma init --with-model

6 participants