Conversation
Contributor
|
Stuck this back in Doing, though currently waiting on #10004 |
aqrln
reviewed
Jan 17, 2022
millsp
commented
Jan 20, 2022
Jolg42
reviewed
Jan 21, 2022
Jolg42
reviewed
Jan 21, 2022
Jolg42
reviewed
Jan 21, 2022
Jolg42
reviewed
Jan 21, 2022
Jolg42
reviewed
Jan 21, 2022
Jolg42
reviewed
Jan 21, 2022
Jolg42
approved these changes
Jan 21, 2022
Contributor
There was a problem hiding this comment.
Well done!
So the refactors are really neat using Proxies, it's much easier to read and has nice docs 💚
About the tracing, someone reading this PR might assume this is a GA feature, so having some preview feature gating would be great before the release.
(+ see comments)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings OpenTelemetry tracing support to the Prisma Client.
The feature is in preview an is guarded by the
tracingfeature flag.I've refactored runtime models while looking at propagation issues.
Note: Waiting to integrate until the engines have tracing support.
closes #10310
Example project that uses tracing for Prisma Client queries:
Setup needed to begin tracing with OTEL,
./otelSetup:What to expect in the visualizer
