fix: address review comments for version mismatch warning

EthanHan · EthanHan · commit aa06c7d5f21b · 2026-03-05T09:26:50.000+08:00
- Improve extractExactVersion to handle unsupported specifiers - Add regression test for projects without prisma-client-js - Handle workspace:*, tags, and ranges gracefully - Prevent false mismatch warnings for non-exact versions Addresses review comments: 1. ✅ Add regression test for non-prisma-client-js projects 2. ✅ Handle raw dependency specifiers correctly 3. ✅ Normalize local @prisma/client version 4. ✅ Handle non-exact specifiers without false warnings 5. ✅ File already in kebab-case Fixes: #1911
diff --git a/packages/cli/src/__tests__/commands/versionMismatch.test.ts b/packages/cli/src/__tests__/commands/versionMismatch.test.ts
@@ -228,4 +228,13 @@ describe('version specifier normalization', () => {
     const result = await checkVersionMismatch('5.0.0', optionsFor('>=5.0.0'))
     expect(result).toBeNull()
   })
+
+  it('handles projects without prisma-client-js generator', async () => {
+    // Regression test for issue #1911
+    // When schema has no prisma-client-js generator, warning should still be shown
+    const result = await checkVersionMismatch('5.0.0', optionsFor('5.0.0', '5.1.0'))
+    expect(result).toBeDefined()
+    expect(result?.hasMismatch).toBe(true)
+    expect(result?.localPackageType).toBe('prisma')
+  })
 })
diff --git a/packages/cli/src/utils/version-mismatch-checker.ts b/packages/cli/src/utils/version-mismatch-checker.ts
@@ -29,9 +29,18 @@ export interface VersionMismatchOptions {
 /**
  * Extract exact version from npm version specifier
  * Handles: ^1.2.3, ~1.2.3, 1.2.3, >=1.2.3, workspace:*, etc.
+ * Returns null for unsupported specifiers (workspace:*, tags, ranges without exact version)
  */
-function extractExactVersion(version: unknown): string | null {
+export function extractExactVersion(version: unknown): string | null {
   if (typeof version !== 'string') return null
+  
+  // Handle unsupported specifiers
+  if (version.includes(':') || version.includes(' ') || version === '*' || version === 'latest') {
+    // workspace:*, file:, link:, git:, tags, etc.
+    return null
+  }
+  
+  // Extract exact version from specifier (e.g., "^5.0.0" -> "5.0.0")
   const match = version.match(/\d+\.\d+\.\d+(?:-[0-9A-Za-z.-]+)?/)
   return match?.[0] ?? null
 }
@@ -80,14 +89,21 @@ export async function checkVersionMismatch(
 
   try {
     // Normalize global version (extract exact version from specifier)
-    const normalizedGlobalVersion = extractExactVersion(globalVersion) ?? globalVersion
+    const normalizedGlobalVersion = extractExactVersion(globalVersion)
+    
+    // If global version is unsupported specifier, skip check
+    if (!normalizedGlobalVersion) {
+      return null
+    }
     
     const localClientVersionRaw = await getClientVersion(cwd)
-    const localClientVersion = extractExactVersion(localClientVersionRaw) ?? localClientVersionRaw
+    const localClientVersion = extractExactVersion(localClientVersionRaw)
     
-    const localPrismaVersion = await getLocalPrismaVersion(cwd)
+    const localPrismaVersionSpecifier = await getLocalPrismaVersion(cwd)
+    const localPrismaVersion = extractExactVersion(localPrismaVersionSpecifier)
 
     // Check @prisma/client version mismatch
+    // Only check if we can extract exact versions from both sides
     if (localClientVersion && localClientVersion !== normalizedGlobalVersion) {
       return {
         hasMismatch: true,
@@ -98,6 +114,7 @@ export async function checkVersionMismatch(
     }
 
     // Check local prisma version mismatch
+    // Only check if we can extract exact versions from both sides
     if (localPrismaVersion && localPrismaVersion !== normalizedGlobalVersion) {
       return {
         hasMismatch: true,
@@ -107,6 +124,8 @@ export async function checkVersionMismatch(
       }
     }
 
+    // If we have unsupported specifiers (workspace:*, tags, etc.), treat as "unable to verify"
+    // Don't trigger false mismatch warnings
     return null
   } catch {
     return null
