Skip to content

fix: #19305 - Docs: Missing type "both" on tooltipEvent#19339

Merged
cetincakiroglu merged 2 commits into
masterfrom
issue-19305
Jan 28, 2026
Merged

fix: #19305 - Docs: Missing type "both" on tooltipEvent#19339
cetincakiroglu merged 2 commits into
masterfrom
issue-19305

Conversation

@mehmetcetin01140

@mehmetcetin01140 mehmetcetin01140 commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

fixes #19305

@github-actions

github-actions Bot commented Jan 27, 2026

Copy link
Copy Markdown

Thank you for your contribution! We will review your PR shortly. Please make sure to manually link it to an issue for proper tracking.

@github-actions

github-actions Bot commented Jan 27, 2026

Copy link
Copy Markdown

AI Code Review

Looks Good

Summary

Updates TypeScript type definitions to include the 'both' option for tooltipEvent, which was already implemented but missing from the type definitions. Also removes unnecessary 'string | any' types for better type safety.

Issue Alignment

Perfectly addresses the issue. The bug report identified that 'both' was a valid value in the implementation but missing from the documentation/types. This PR adds 'both' to both the TooltipOptions interface and the Tooltip component's @input decorator type.

This is an automated review. A maintainer will provide final approval.

@vercel

vercel Bot commented Jan 27, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
primeng Error Error Jan 27, 2026 2:01pm
primeng-5lp7 Ready Ready Preview, Comment Jan 27, 2026 2:01pm

@github-actions

github-actions Bot commented Jan 27, 2026

Copy link
Copy Markdown

Thanks a lot for your contribution! But, Unit tests failed. You can check the unit tests with the command 'pnpm run test:unit' and commit the changes.

@cetincakiroglu cetincakiroglu merged commit 14d6834 into master Jan 28, 2026
4 of 6 checks passed
@cetincakiroglu cetincakiroglu deleted the issue-19305 branch January 28, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cetincakiroglu cetincakiroglu cetincakiroglu approved these changes

Assignees

No one assigned

Labels

bot: looks-good

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: Missing type "both" on tooltipEvent

2 participants

@mehmetcetin01140 @cetincakiroglu