fix: #19276 - Block UI doesn't work with Card with ngtemplate #header#19283
Merged
Conversation
|
Thank you for your contribution! We will review your PR shortly. Please make sure to manually link it to an issue for proper tracking. |
AI Code ReviewLooks Good SummaryFixes BlockUI masking issue with Card component by changing getBlockableElement() to return the host element instead of the first child element Issue AlignmentExcellent. The PR directly addresses the issue where BlockUI only covered the header when Card used ng-template #header. The root cause was that getBlockableElement() returned the first child (which could be just the header), and the fix correctly changes it to return the host element (the entire card). This is an automated review. A maintainer will provide final approval. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #19276