Skip to content

fix: #19251#19282

Merged
cetincakiroglu merged 1 commit into
masterfrom
issue-19251
Jan 28, 2026
Merged

fix: #19251#19282
cetincakiroglu merged 1 commit into
masterfrom
issue-19251

Conversation

@mehmetcetin01140

@mehmetcetin01140 mehmetcetin01140 commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

fixes #19251

@github-actions

github-actions Bot commented Jan 15, 2026

Copy link
Copy Markdown

Thank you for your contribution! We will review your PR shortly. Please make sure to manually link it to an issue for proper tracking.

@github-actions

github-actions Bot commented Jan 15, 2026

Copy link
Copy Markdown

AI Code Review

Looks Good

Summary

Removes the blockScroll condition check when cleaning up the p-overflow-hidden class from the document body during dialog destruction, ensuring the class is always removed when the dialog is destroyed.

Issue Alignment

This change directly addresses the issue where the .p-overflow-hidden class was not being removed from the body when a conditionally displayed modal dialog was closed. The issue occurred because the blockScroll condition prevented cleanup in certain scenarios when the dialog was destroyed via @if block.

This is an automated review. A maintainer will provide final approval.

@vercel

vercel Bot commented Jan 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
primeng-5lp7 Ready Ready Preview, Comment Jan 15, 2026 9:59am

@jase88 jase88 mentioned this pull request Jan 22, 2026
Closed
4 tasks
@cetincakiroglu cetincakiroglu merged commit 0a047cb into master Jan 28, 2026
5 of 6 checks passed
@cetincakiroglu cetincakiroglu deleted the issue-19251 branch January 28, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bot: looks-good

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.p-overflow-hidden not removed from body when closing conditionally displayed modal dialog

2 participants

@mehmetcetin01140 @cetincakiroglu