You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix#18296
Fixed memory leak in AccordionContent component.
While investigating the memory leak I determined the problem was caused by the component's use of animation. I initially assumed the problem was caused by the implementation of signals. I confirmed that signals was not causing the problem. I then compared the current v19 Accordion code with the deprecated AccordionTab, since v17 PrimeNG demo didn't have the memory leak. The difference between the animation implementation was that v17 animation was attached to the content DIV and v19 animation was attached to the host. Moving the animation back to the content DIV fixed the memory leak.
The video listed below shows this PR fixes the memory leak is fixed
Ignore this comment. See next comment. PR is good to go.
After additional testing, I'm not sure this is the optimal solution. After this fix, the animation is not as smooth as before the fix. I don't know how to fix this or even if this can be fixed.
Accordions can contain a large amount of data, so this memory leak has to be fixed.
The video listed below shows the animation before and after the fix. The left browser is the v19 demo and the right browser is after the fix.
cetincakiroglu
added
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
and removed
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
labels
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #18296
Fixed memory leak in AccordionContent component.
While investigating the memory leak I determined the problem was caused by the component's use of animation. I initially assumed the problem was caused by the implementation of signals. I confirmed that signals was not causing the problem. I then compared the current v19 Accordion code with the deprecated AccordionTab, since v17 PrimeNG demo didn't have the memory leak. The difference between the animation implementation was that v17 animation was attached to the content DIV and v19 animation was attached to the host. Moving the animation back to the content DIV fixed the memory leak.
The video listed below shows this PR fixes the memory leak is fixed
AccordionAfterFixGood.mov