fix resolveConfig to work with Prettier 3#942
Merged
JounQin merged 5 commits intoprettier:masterfrom Oct 27, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 7f93b14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5a3479b to
b53b2b4
Compare
The `sync` function is gone and only async version exists.
39e7dc5 to
a4efafb
Compare
a4efafb to
86639d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #942 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 295 291 -4
Branches 85 82 -3
=========================================
- Hits 295 291 -4
☔ View full report in Codecov by Sentry. |
JounQin
reviewed
Oct 27, 2023
JounQin
reviewed
Oct 27, 2023
JounQin
approved these changes
Oct 27, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
syncfunction is gone and only async version exists.Also remove
eslintPathargument that test function does not consume.