Conversation
🦋 Changeset detectedLatest commit: 8778400 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 7a5e675 in 31 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. package.json:29
- Draft comment:
Removed the preinstall script causing global install errors. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is purely informative, stating what was done without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest improvements.
2. package.json:71
- Draft comment:
Removed the unused dependency 'only-allow' after deleting the preinstall script. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is purely informative, as it simply states what was done without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any improvements.
3. package.json:29
- Draft comment:
Removal of the preinstall script is correct. This avoids invokingnpx only-allow npmduring global installs, which resolves the CI issue. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is purely informative, as it simply states that the removal of the preinstall script resolves a CI issue. It does not provide any actionable feedback or suggestions for improvement.
4. package.json:71
- Draft comment:
Removing the "only-allow" dependency is appropriate since its associated preinstall script has been removed. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that removing a dependency is appropriate, which is not necessary for the PR author to know.
Workflow ID: wflow_Jn0g5Iq5HLwR6m6q
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1176 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 303 303
Branches 84 84
=========================================
Hits 303 303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1175
Important
Remove
preinstallscript andonly-allowdependency frompackage.json.preinstallscript frompackage.jsonwhich enforced npm usage vianpx only-allow npm.only-allowfromdevDependenciesinpackage.json.This description was created by
for 7a5e675. It will automatically update as commits are pushed.