Hi,
Similar to #119, after disabling "Fix errors on save" in linter-eslint and enabling ESLint integration, saving doesn't seem to run the eslint --fix formatting.
✓ eslint --fix on CLI works as expected.
✓ prettier-eslint on CLI works as expected.
✓ linter-eslint Atom plugin with "Fix errors on save" works as expected.
✓ Prettier Atom plugin works as expected without ESLint integration.
✗ Prettier Atom plugin does not works as expected with ESLint integration.
For this case, I created a minimal repo: https://github.com/ozum/case-prettier-atom-eslint
Please note that I also included zipped version of .atom folder (~50 MB) in the repo.
In that repo index.js should be added a dangling comma before save, but it is not added.
Kind Regards,
Details
Atom version: 1.23.1
prettier-atom version: 0.44.0
prettier version: 1.9.2
prettier-eslint version: 8.7.0
prettier-atom configuration: {
"formatOnSaveOptions": {
"enabled": true,
"respectEslintignore": true,
"showInStatusBar": false,
"javascriptScopes": [
"source.js",
"source.jsx",
"source.js.jsx",
"source.babel",
"source.js-semantic",
"text.html.basic",
"text.html.vue"
],
"typescriptScopes": [
"source.ts",
"source.tsx",
"source.ts.tsx"
],
"cssScopes": [
"source.css",
"source.less",
"source.css.less",
"source.scss",
"source.css.scss",
"source.css.postcss"
],
"jsonScopes": [
"source.json"
],
"graphQlScopes": [
"source.graphql"
],
"markdownScopes": [
"source.md",
"source.gfm",
"text.md"
],
"excludedGlobs": [],
"whitelistedGlobs": [],
"isDisabledIfNotInPackageJson": false,
"isDisabledIfNoConfigFile": false
},
"prettierEslintOptions": {
"prettierLast": false
},
"useEslint": true,
"useStylelint": false,
"useEditorConfig": true,
"prettierOptions": {
"singleQuote": false,
"bracketSpacing": true,
"semi": true,
"useTabs": false,
"jsxBracketSameLine": false,
"printWidth": 80,
"tabWidth": "auto",
"trailingComma": "none",
"parser": "babylon"
}
}
Hi,
Similar to #119, after disabling "Fix errors on save" in
linter-eslintand enabling ESLint integration, saving doesn't seem to run theeslint --fixformatting.✓
eslint --fixon CLI works as expected.✓
prettier-eslinton CLI works as expected.✓
linter-eslintAtom plugin with "Fix errors on save" works as expected.✓
Prettier Atomplugin works as expected without ESLint integration.✗
Prettier Atomplugin does not works as expected with ESLint integration.For this case, I created a minimal repo: https://github.com/ozum/case-prettier-atom-eslint
Please note that I also included zipped version of .atom folder (~50 MB) in the repo.
In that repo
index.jsshould be added a dangling comma before save, but it is not added.Kind Regards,
Details
Atom version: 1.23.1 prettier-atom version: 0.44.0 prettier version: 1.9.2 prettier-eslint version: 8.7.0 prettier-atom configuration: { "formatOnSaveOptions": { "enabled": true, "respectEslintignore": true, "showInStatusBar": false, "javascriptScopes": [ "source.js", "source.jsx", "source.js.jsx", "source.babel", "source.js-semantic", "text.html.basic", "text.html.vue" ], "typescriptScopes": [ "source.ts", "source.tsx", "source.ts.tsx" ], "cssScopes": [ "source.css", "source.less", "source.css.less", "source.scss", "source.css.scss", "source.css.postcss" ], "jsonScopes": [ "source.json" ], "graphQlScopes": [ "source.graphql" ], "markdownScopes": [ "source.md", "source.gfm", "text.md" ], "excludedGlobs": [], "whitelistedGlobs": [], "isDisabledIfNotInPackageJson": false, "isDisabledIfNoConfigFile": false }, "prettierEslintOptions": { "prettierLast": false }, "useEslint": true, "useStylelint": false, "useEditorConfig": true, "prettierOptions": { "singleQuote": false, "bracketSpacing": true, "semi": true, "useTabs": false, "jsxBracketSameLine": false, "printWidth": 80, "tabWidth": "auto", "trailingComma": "none", "parser": "babylon" } }