Replace null in ArrayExpression and ArrayPattern with Null node#9857
Open
fisker wants to merge 7 commits intoprettier:mainfrom
Open
Replace null in ArrayExpression and ArrayPattern with Null node#9857fisker wants to merge 7 commits intoprettier:mainfrom
null in ArrayExpression and ArrayPattern with Null node#9857fisker wants to merge 7 commits intoprettier:mainfrom
Conversation
| } | ||
| } | ||
|
|
||
| function replaceNullElements(node, ast, options) { |
Contributor
There was a problem hiding this comment.
Please add a comment that explain motivation to introduce Null node or link to this PR.
sosukesuzuki
approved these changes
Dec 17, 2020
Contributor
sosukesuzuki
left a comment
There was a problem hiding this comment.
@thorn0 Could you review?
2 tasks
Are these tracked somewhere? By And I thought of one more case: call(foo,,/*a*/,/*b*/,bar) |
Member
Author
Yes, opened an issue to track this #10046 |
4 tasks
Contributor
|
🤔 Still blocked? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a dummy node for
nullin array, so we can attach comments. This solution should work for other similar problem, like #9787 (comment) orfor(;;);Fixes #1013
Fixes #9299
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨