Fix babel-ts to emit a proper syntax error for (a:b)#8046
Merged
thorn0 merged 1 commit intoprettier:masterfrom May 15, 2020
Merged
Fix babel-ts to emit a proper syntax error for (a:b)#8046thorn0 merged 1 commit intoprettier:masterfrom
(a:b)#8046thorn0 merged 1 commit intoprettier:masterfrom
Conversation
e11d7f7 to
a46bf82
Compare
(a:b)(a:b)
Member
|
Is it possible to access this |
Member
Author
|
No, they aren't exported. |
Member
function getTSUnexpectedTypeAnnotation() {
try{
parser('(a:b)');
} catch({message}){
return message;
}
}Too hacky? 😄 |
fisker
approved these changes
May 13, 2020
Member
Author
|
We have it under control. The test will fail if the message suddenly changes. |
fisker
reviewed
May 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show a proper syntax error instead.
Fixes #8041
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨