Partial support for TypeScript 3.8 (private fields, import/export type modifier)#7631
Conversation
6acb9e5 to
7707dde
Compare
sosukesuzuki
left a comment
There was a problem hiding this comment.
TypeScript 3.8 supports top-level await, so this pr will fix #6608
|
typescript-estree v2.23.0 has been released which contains support for the The other parts of typescript-eslint/typescript-eslint#1436 have not yet been released as their AST spec has not yet been finalized. It seems like these may take a while to get consensus on so I'd be very tempted to not wait for them.
|
63ba70d to
869b396
Compare
| | ------------------------------------------------------------------------------------------------------------------------------- | ------------------- | ----------------- | | ||
| | [Type-Only Imports and Exports](https://devblogs.microsoft.com/typescript/announcing-typescript-3-8/#type-only-imports-exports) | ✔️ | ❌ | | ||
| | [ECMAScript Private Fields](https://devblogs.microsoft.com/typescript/announcing-typescript-3-8/#ecmascript-private-fields) | ✔️ | ✔️ | | ||
| | [`export * as ns`](https://devblogs.microsoft.com/typescript/announcing-typescript-3-8/#export-star-as-namespace-syntax) | ❌ | ❌ | |
There was a problem hiding this comment.
export * as ns seems to be supported with babel-ts.
Playground
parser=babel-ts
Input:
export * as foo from './foo';Output
export * as foo from "./foo";There was a problem hiding this comment.
You're right. Overlooked this somehow. I'll fix the changelog.
| export type { A as B }; | ||
| export type { B as C } from "./a"; | ||
| export type { foo } from "bar"; | ||
| export type * from "bar"; |
There was a problem hiding this comment.
@thorn0 Is this test needed? TS Playground says "Only named exports may use 'export type'.".
https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=2&pc=1#code/KYDwDg9gTgLgBDAnmYcBUcBmUIFs4BEARgIZQEDcAUEA
There was a problem hiding this comment.
Let's remove this test. Babel 7.9.0 can't parse it.
issue: #7263
typescript-estree issue: typescript-eslint/typescript-eslint#1436
✨Try the playground for this PR✨