Skip to content

fix indentation in ternaries nested in conditions of other ternaries #7087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexander-akait merged 8 commits into from
Dec 4, 2019
Merged

fix indentation in ternaries nested in conditions of other ternaries #7087

alexander-akait merged 8 commits into from
Dec 4, 2019

Conversation

@thorn0
Copy link
Member

@thorn0 thorn0 commented Dec 3, 2019 •
edited
Loading

fixes #5257

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

thorn0
thorn0 commented Dec 3, 2019
View reviewed changes
thorn0
thorn0 commented Dec 3, 2019
View reviewed changes
alexander-akait
alexander-akait approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@thorn0
Copy link
Member Author

thorn0 commented Dec 3, 2019

There are still some problems with TS conditional types. Don't merge it yet.

@thorn0
Copy link
Member Author

thorn0 commented Dec 3, 2019

Ready for review.

@brody4hire brody4hire mentioned this pull request Dec 4, 2019
Open
@alexander-akait
Copy link
Member

alexander-akait commented Dec 4, 2019

Great job!

@alexander-akait alexander-akait merged commit 3c13329 into prettier:master Dec 4, 2019
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Mar 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
@thorn0 thorn0 deleted the fix5257 branch February 13, 2021 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lydell lydell lydell approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

invalid indent with nested ternary in test

4 participants

@thorn0 @alexander-akait @lydell @sosukesuzuki