fix(javascript): skip .connect() method when composing fun#5739
Merged
suchipi merged 1 commit intoprettier:masterfrom Jan 10, 2019
nykula:master
Merged
fix(javascript): skip .connect() method when composing fun#5739suchipi merged 1 commit intoprettier:masterfrom nykula:master
suchipi merged 1 commit intoprettier:masterfrom
nykula:master
Conversation
j-f1
approved these changes
Jan 10, 2019
suchipi
approved these changes
Jan 10, 2019
Member
|
Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4935. Checks a member expression property against an ordinary method name blacklist, after the property has found a match in the existing set of function composer names.
✨Try the playground for this PR✨