fix(css-in-js) Keep newlines in CSS-in-JS Templates (Fixes: #5147)#5240
Merged
lipis merged 5 commits intoprettier:masterfrom Nov 1, 2018
Merged
Conversation
| \`; | ||
|
|
||
| styled.span\` | ||
| \${foo}: \${bar}; |
Member
There was a problem hiding this comment.
Looks we insert unnecessary semicolon, need fix it
| \`; | ||
|
|
||
| styled.span\` | ||
| \${foo}: \${bar}; |
Member
There was a problem hiding this comment.
Also semicolon was inserted 😞
Contributor
Author
|
@evilebottnawi updated 😊 |
lydell
approved these changes
Oct 18, 2018
Member
|
@onurtemizkan Looks i find one strange problem, maybe not related, maybe related, will be great if you investigate. Input: export const FlexBox = styled.div`
${$var}
> * {
width: ${p => (p.howManyPerRow ? `${100 / p.howManyPerRow}%` : 'auto')};
}
`Output: export const FlexBox = styled.div`
${$var}
> * {
width: ${p => (p.howManyPerRow ? `${100 / p.howManyPerRow}%` : "auto")};
}
`;All fine. But: Input: export const FlexBox = styled.div`
${$var}
> * {
width: ${p => (p.howManyPerRow ? `${100 / p.howManyPerRow}%` : 'auto')};
}
`Output: export const FlexBox = styled.div`
${$var}
> * {
width: ${p => (p.howManyPerRow ? `${100 / p.howManyPerRow}%` : "auto")};
}
`;
|
Contributor
Author
|
@evilebottnawi Sure, checking. |
Member
|
@onurtemizkan Did you find anything? Would be awesome to get this into the next release. I guess we could merge as-is, too. |
Contributor
Author
|
@lydell, I haven't found it yet. Let's merge this and I'll create another issue to continue if it's ok. |
lipis
approved these changes
Nov 1, 2018
Member
|
Shall we take this in..? |
Member
|
@lipis feel free to merge, problem with indent should be solved in other PR |
This was referenced Nov 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5147
Keep newlines after CSS-in-JS quasi-literal substitutes.
docs/directory)