Skip to content

fix(typescript) Do not add extra semicolon to TSMethodSignature when prettier-ignore is used (#5140)#5160

Merged
j-f1 merged 1 commit intoprettier:masterfrom
onurtemizkan:fix/ts/ignore-method-signature-semi
Sep 29, 2018
Merged

fix(typescript) Do not add extra semicolon to TSMethodSignature when prettier-ignore is used (#5140)#5160
j-f1 merged 1 commit intoprettier:masterfrom
onurtemizkan:fix/ts/ignore-method-signature-semi

Conversation

@onurtemizkan
Copy link
Copy Markdown
Contributor

@onurtemizkan onurtemizkan commented Sep 29, 2018

Fixes: #5140

Separator paths are shifted for TSMethodSignatures when prettier-ignore is used, just as TSPropertySignatures.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@onurtemizkan onurtemizkan changed the title fix(typescript) Do not add extra semicolon to TSMethodSignature when prettier-ingore is used (#5140) fix(typescript) Do not add extra semicolon to TSMethodSignature when prettier-ignore is used (#5140) Sep 29, 2018
@onurtemizkan onurtemizkan force-pushed the fix/ts/ignore-method-signature-semi branch from 58c9a42 to c4bb11e Compare September 29, 2018 08:59
j-f1
j-f1 approved these changes Sep 29, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@j-f1 j-f1 merged commit cc83a27 into prettier:master Sep 29, 2018
@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018
@Swatinem Swatinem mentioned this pull request Nov 12, 2018
Closed
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@j-f1 j-f1 j-f1 approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.15

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan @j-f1 @ikatyang