Skip to content

fix(html): preserve case-sensitive attributes#5109

Merged
ikatyang merged 4 commits intoprettier:masterfrom
ikatyang:fix/html/case-sensitive-attributes
Sep 19, 2018
Merged

fix(html): preserve case-sensitive attributes#5109
ikatyang merged 4 commits intoprettier:masterfrom
ikatyang:fix/html/case-sensitive-attributes

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Sep 19, 2018 •
edited
Loading

Attributes in non-HTML tags are considered case-sensitive.

Prettier pr-5109
Playground link

--parser parse5

Input:

<CaseSensitive CaseSensitive>hello world</CaseSensitive>
<Div CaseInsensitive>hello world</Div>

Output:

<CaseSensitive CaseSensitive>hello world</CaseSensitive>
<div caseinsensitive>hello world</div>
  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@ikatyang ikatyang mentioned this pull request Sep 19, 2018
Closed
26 tasks
@ikatyang ikatyang merged commit 02fcea0 into prettier:master Sep 19, 2018
@ikatyang ikatyang deleted the fix/html/case-sensitive-attributes branch September 19, 2018 13:36
@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.15

Development

Successfully merging this pull request may close these issues.

2 participants

@ikatyang @alexander-akait