Skip to content

fix(html): exclude comments from fragment detection#5100

Merged
ikatyang merged 3 commits intoprettier:masterfrom
ikatyang:fix/html/fragment-detection
Sep 17, 2018
Merged

fix(html): exclude comments from fragment detection#5100
ikatyang merged 3 commits intoprettier:masterfrom
ikatyang:fix/html/fragment-detection

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Sep 16, 2018

Context: #4753 (comment)

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@ikatyang ikatyang mentioned this pull request Sep 16, 2018
Closed
26 tasks
@ikatyang ikatyang merged commit 79d510c into prettier:master Sep 17, 2018
@ikatyang ikatyang deleted the fix/html/fragment-detection branch September 17, 2018 13:38
@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.15

Development

Successfully merging this pull request may close these issues.

2 participants

@ikatyang @alexander-akait