Merged
Conversation
jlongster
reviewed
Jan 26, 2017
| if (text.charAt(index - 1) === "\r") { | ||
| return "\r\n"; | ||
| } | ||
| return "\n"; |
Member
There was a problem hiding this comment.
This could be simplified as:
const index = text.indexOf('\n');
if(index >= 0 && text.charAt(index - 1) === "\r") {
return "\r\n";
}
return "\n";
Member
|
Looks generally good, I think that function could be made a tiny bit clearer, then feel free to merge! |
It's nice that we print line endings in a single place, it was super easy to preserve them :) Fixes prettier#92
3b10dc7 to
83e3b37
Compare
Contributor
Author
|
Rebased and addressed comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's nice that we print line endings in a single place, it was super easy to preserve them :)
Fixes #92