Skip to content

feat(markdown): change unordered list symbol to hyphen#4440

Merged
ikatyang merged 1 commit intoprettier:masterfrom
ikatyang:feat/markdown-unordered-list-symbol-hyphen
May 10, 2018
Merged

feat(markdown): change unordered list symbol to hyphen#4440
ikatyang merged 1 commit intoprettier:masterfrom
ikatyang:feat/markdown-unordered-list-symbol-hyphen

Conversation

@ikatyang
Copy link
Member

@ikatyang ikatyang commented May 8, 2018

Fixes #4251

@kachkaev
Copy link
Member

kachkaev commented May 8, 2018

Is it due 1.13, not 2.0? 😨

@lipis
Copy link
Member

lipis commented May 8, 2018

@duailibe
Copy link
Collaborator

duailibe commented May 8, 2018

@kachkaev Every minor version of Prettier possibly changes the way you format the code. We've done similar stuff in the past, it doesn't warrant a 2.0.

@lipis
Copy link
Member

lipis commented May 8, 2018

What about alternating the symbol for nested lists?

#4251 (comment) by @infotexture

- Item 1
  * Item 2
    + Item 3
  * Item 4
- Item 4
  * Item 5

@ikatyang
Copy link
Member Author

ikatyang commented May 8, 2018

It's out of scope of this PR and I don't have strong opinion on that. We should open another issue to see how people think about it.

@lipis lipis added this to the 1.13 milestone May 9, 2018
@lipis lipis mentioned this pull request May 9, 2018
@ikatyang ikatyang merged commit 6447d30 into prettier:master May 10, 2018
@ikatyang ikatyang deleted the feat/markdown-unordered-list-symbol-hyphen branch May 10, 2018 06:32
@ashfurrow
Copy link

How exciting – thank you!

@lipis
Copy link
Member

lipis commented May 10, 2018

Coming soon to your nearest editor :)

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Aug 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants