Do not prepend / append with a semicolon the only JSX element in a program#3330
Merged
suchipi merged 3 commits intoprettier:masterfrom Nov 28, 2017
sapegin:jsx-only-elem
Merged
Do not prepend / append with a semicolon the only JSX element in a program#3330suchipi merged 3 commits intoprettier:masterfrom sapegin:jsx-only-elem
suchipi merged 3 commits intoprettier:masterfrom
sapegin:jsx-only-elem
Conversation
Member
One way to do this is expose the parent parser: multiparser.js: next.options = Object.assign({}, options, next.options, {
+ parentParser: options.parser,
originalText: next.text
});Then check with: if (options.parentParser === "markdown") {
// ...
} |
Contributor
Author
|
@azz Thanks, it seems to work! Please have a look. Is there anything I need to change? This is my first PR to Prettier ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m not sure how to check that we’re inside Markdown.Fixes #3196.