docs(readme): add description for markdown support#3028
Closed
ikatyang wants to merge 2 commits intoprettier:masterfrom
Closed
docs(readme): add description for markdown support#3028ikatyang wants to merge 2 commits intoprettier:masterfrom
ikatyang wants to merge 2 commits intoprettier:masterfrom
Conversation
azz
approved these changes
Oct 14, 2017
Member
azz
left a comment
There was a problem hiding this comment.
We can wait until a bit closer to 1.8 before merging.
lipis
reviewed
Oct 31, 2017
| `tests/flow` *is* the entire Flow test suite and they all pass. | ||
|
|
||
| Prettier also supports [TypeScript](https://www.typescriptlang.org/), CSS, [Less](http://lesscss.org/), [SCSS](http://sass-lang.com), [JSON](http://json.org/), and [GraphQL](http://graphql.org/). | ||
| Prettier also supports [TypeScript](https://www.typescriptlang.org/), CSS, [Less](http://lesscss.org/), [SCSS](http://sass-lang.com), [JSON](http://json.org/), [GraphQL](http://graphql.org/), and [Markdown](http://commonmark.org/). |
Member
There was a problem hiding this comment.
I think we don't need comma (,) before and.
Contributor
There was a problem hiding this comment.
I mean, that's the whole "oxford comma" debate, isn't it?
(Disclaimer: I love the oxford comma.)
Given that the file had the comma before, I'd think that it ought to still have it. 😃
Member
Author
There was a problem hiding this comment.
Not sure which one is better, remain the same style as before.
Member
There was a problem hiding this comment.
I am pro Oxford and trailing comma 😉
e54564f to
3b4f0a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.