Skip to content

Markdown: Fix parse error in liquid plugin#19411

Merged
fisker merged 7 commits into
prettier:mainfrom
seiyab:refine-liquid-plugin
Jun 23, 2026
Merged

Markdown: Fix parse error in liquid plugin#19411
fisker merged 7 commits into
prettier:mainfrom
seiyab:refine-liquid-plugin

Conversation

@seiyab

@seiyab seiyab commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes #19386

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.
  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

@pkg-pr-new

pkg-pr-new Bot commented Jun 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

yarn add https://pkg.pr.new/@prettier/plugin-hermes@19411.tgz
yarn add https://pkg.pr.new/@prettier/plugin-oxc@19411.tgz
yarn add https://pkg.pr.new/prettier@19411.tgz

commit: d3e284c

@netlify

netlify Bot commented Jun 21, 2026

Copy link
Copy Markdown

Deploy Preview for prettier ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d3e284c
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/6a3a3d550360e70008d35421
😎 Deploy Preview https://deploy-preview-19411--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@fisker fisker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please make sure the checklist is checked.

@seiyab

seiyab commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

Ah, thank you for your reaciton. I'm still reviewing myself again (already reviewed locally once but want to understand/think deeper).

@fisker

fisker commented Jun 22, 2026

Copy link
Copy Markdown
Member

You can set to draft if not ready.

@seiyab seiyab marked this pull request as draft June 22, 2026 05:55
@fisker fisker added this to the 3.9 milestone Jun 22, 2026
@seiyab seiyab marked this pull request as ready for review June 22, 2026 13:48
@seiyab

seiyab commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

@fisker Its ready now.

@seiyab seiyab requested a review from fisker June 22, 2026 13:49

/** @type {Handle} */
function enterInlineMath(token) {
function enterInlineLiquid(token) {

@fisker fisker Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just {enter,exit}Liquid?

@fisker fisker changed the title Fix parse error in liquid plugin Markdown: Fix parse error in liquid plugin Jun 23, 2026
@fisker fisker merged commit bf3ca0c into prettier:main Jun 23, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown file fail to parse

2 participants