Keep comments in mapped type inline#18731
Merged
fisker merged 9 commits intoprettier:mainfrom Jan 24, 2026
Merged
Conversation
commit: |
9593ed7 to
c2dafd8
Compare
✅ Deploy Preview for prettier ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for prettier ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fisker
commented
Jan 23, 2026
Comment on lines
+60
to
+67
| type M4 = { | ||
| /* a long long long long long long long long long long long long long long comment */ [b in B]: string | ||
| } | ||
|
|
||
| type M5 = { | ||
| /* Multi | ||
| line */ [b in B]: string | ||
| } |
Member
Author
There was a problem hiding this comment.
@Dunqing I think these two should on own line, oxfmt currently not.
Contributor
There was a problem hiding this comment.
Thank you! I will follow it up in the Oxfmt.
8 tasks
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18730
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.