Enhance binary cast expression handling and add tests for trace entrypoints#18492
Closed
williamquintas wants to merge 2 commits intoprettier:mainfrom
Closed
Enhance binary cast expression handling and add tests for trace entrypoints#18492williamquintas wants to merge 2 commits intoprettier:mainfrom
williamquintas wants to merge 2 commits intoprettier:mainfrom
Conversation
… points - Updated `printBinaryCastExpression` to handle `NewExpression` in addition to `CallExpression`. - Introduced a new test file for TypeScript chain expressions involving `TraceEntryPointsPlugin`. - Updated snapshots to reflect the new formatting for the added test cases.
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
…t expression handling.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18406
Description
printBinaryCastExpressionto handleNewExpressionin addition toCallExpression.TraceEntryPointsPlugin.Checklist
Tests added/updated:
tests/format/typescript/chain-expression/snapshots/format.test.js.snap
tests/format/typescript/chain-expression/trace-entrypoints.ts
How to run: yarn test (and yarn test -u if snapshots were updated).
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
(If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
Changelog file: changelog_unreleased/typescript/18492.md
I’ve read the contributing guidelines.