Remove unused shouldBreak check in printTernaryOld#18354
Merged
fisker merged 1 commit intoprettier:mainfrom Nov 28, 2025
Merged
Remove unused shouldBreak check in printTernaryOld#18354fisker merged 1 commit intoprettier:mainfrom
shouldBreak check in printTernaryOld#18354fisker merged 1 commit intoprettier:mainfrom
Conversation
commit: |
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
Thanks, I checked history, it seems starts with some case for JSX e17bb5e but later check comments instead. Should be safe to remove. |
fisker
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While debugging
oxc_formatter, I noticed this condition seems unnecessary.(Since it's certain to break when comments are printed?)
If you have any concerns, feel free to close it.
(And if you do, I'd appreciate it if you could let us know why.)
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.