Skip to content

Pass ancestors to plugin.print.canAttachComment()#18055

Merged
fisker merged 18 commits intoprettier:mainfrom
fisker:ancestors
Oct 12, 2025
Merged

Pass ancestors to plugin.print.canAttachComment()#18055
fisker merged 18 commits intoprettier:mainfrom
fisker:ancestors

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Oct 12, 2025

Description

Fixes #18054

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Oct 12, 2025 •
edited
Loading

Open in StackBlitz

yarn add https://pkg.pr.new/prettier/prettier/@prettier/plugin-hermes@18055.tgz

yarn add https://pkg.pr.new/prettier/prettier/@prettier/plugin-oxc@18055.tgz

yarn add https://pkg.pr.new/prettier/prettier@18055.tgz

commit: 0dfa83d

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 12, 2025

✅ Deploy Preview for prettier ready!

Name Link
🔨 Latest commit e685483
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/68eb17da46190f0008978ae1
😎 Deploy Preview https://deploy-preview-18055--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 12, 2025 •
edited
Loading

✅ Deploy Preview for prettier ready!

Name Link
🔨 Latest commit beb27c7
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/68eb946473e2960008c806d7
😎 Deploy Preview https://deploy-preview-18055--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fisker fisker marked this pull request as ready for review October 12, 2025 11:56
@fisker fisker merged commit 0f74812 into prettier:main Oct 12, 2025
31 of 32 checks passed
@fisker fisker deleted the ancestors branch October 12, 2025 11:56
This was referenced Oct 18, 2025
Merged
Closed
Copilot AI mentioned this pull request Nov 19, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pass parent to plugin.print.canAttachComment

1 participant

@fisker