Skip to content

Support TemplateLiteral introduced in Angular 19.2 #17238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fisker merged 8 commits into from
Mar 17, 2025
Merged

Support TemplateLiteral introduced in Angular 19.2 #17238

fisker merged 8 commits into from
Mar 17, 2025

Conversation

@fisker
Copy link
Member

@fisker fisker commented Mar 11, 2025 •
edited
Loading

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 11, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/prettier@17238

commit: 1987703

@netlify
Copy link

netlify bot commented Mar 11, 2025 •
edited
Loading

✅ Deploy Preview for prettier ready!

Name Link
🔨 Latest commit 1987703
🔍 Latest deploy log https://app.netlify.com/sites/prettier/deploys/67d1d1c5b871f00008bc7819
😎 Deploy Preview https://deploy-preview-17238--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fisker fisker marked this pull request as draft March 11, 2025 07:51
@fisker
Copy link
Member Author

fisker commented Mar 11, 2025

Seems we have more work to do in angular-estree-parser

@fisker fisker changed the title Update angular estree Support Angular 19.2 Mar 11, 2025
@fisker fisker changed the title Support Angular 19.2 Support TemplateLiteral introduced in Angular 19.2 Mar 11, 2025
@fisker fisker marked this pull request as ready for review March 11, 2025 09:42
@fisker fisker marked this pull request as draft March 11, 2025 10:30
@fisker

This comment was marked as outdated.

Sign in to view
This was referenced Mar 11, 2025
Closed
Closed
@fisker fisker marked this pull request as ready for review March 12, 2025 18:27
@fisker fisker mentioned this pull request Mar 13, 2025
Closed
1 task
@fisker fisker merged commit 44d7298 into prettier:main Mar 17, 2025
34 checks passed
@fisker fisker deleted the angular-19-2 branch March 17, 2025 03:20
@fisker fisker mentioned this pull request Mar 18, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker @sosukesuzuki