Markdown: Don't break a line at the place around Chinese or Japanese characters #16691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
8ae9377 to
7a095e4
Compare
Contributor
Author
|
This force push is just a rebase to |
2662898 to
91570bd
Compare
tats-u
commented
Sep 30, 2024
Comment on lines
+37
to
+38
| かつてはワ行のワ、ヰ、ヱ、ヲに濁点を付して [v] | ||
| 音を表現すること（ワ゛、ヰ゛、ヱ゛、ヲ゛）も行われたが、一般的にはならなかった。 |
Contributor
Author
There was a problem hiding this comment.
When prev or next is undefined, " " and "\n" have been interchangeable.
sosukesuzuki
reviewed
Oct 1, 2024
Co-authored-by: SUZUKI Sosuke <aosukeke@gmail.com>
fisker
approved these changes
Oct 18, 2024
This was referenced Nov 6, 2024
Thompson1985
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16710
Description
The 2nd safest part of #15081
All HTML browsers (even Firefox) insert space between Chinese/Japanese and others.
https://wpt.fyi/results/css/css-text/line-breaking?label=master&label=experimental&aligned&q=segment-break-transformation- (See only those that all browsers pass)
FYI, FIrefox treats the following characters in BMP and SSP (Plane 0-1) as Chinese/Japanese:
https://github.com/tats-u/cj-newline-test/?tab=readme-ov-file#result-in-firefox
The current behavior of Prettier (3.x) with
proseWrapalwaysconflicts with it.This change will help Markdown documents converted to HTML or JS components to be rendered more correctly by browsers.
Note: this doesn't affect on line breaks between Chinese/Japanese and Korean letters because a space and a line break there is equivalent.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨