Skip to content

Safely remove quotes from keys in Import Attributes#15564

Closed
sosukesuzuki wants to merge 5 commits intoprettier:mainfrom
sosukesuzuki:fix-import-attributes-key-print
Closed

Safely remove quotes from keys in Import Attributes#15564
sosukesuzuki wants to merge 5 commits intoprettier:mainfrom
sosukesuzuki:fix-import-attributes-key-print

Conversation

@sosukesuzuki
Copy link
Copy Markdown
Contributor

Description

Fixes #15563

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@sosukesuzuki
Copy link
Copy Markdown
Contributor Author

For some reason FULL_TEST is failing. I'll investigate later.

}
}

function printImportAttribute(path, options, print) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we use printProperty directly?

@fisker fisker force-pushed the fix-import-attributes-key-print branch from 70b711b to 2a360c9 Compare November 27, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove quotes in import attribute

2 participants