Add typing to support readonly array properties of AST Node
#15127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Jul 18, 2023
| /** After */ | ||
| // Now works fine too | ||
| path.map(() => "", "readonlyArray"); | ||
| ``` |
Member
There was a problem hiding this comment.
We use Prettier stable and Prettier main instead of before/after. https://github.com/prettier/prettier/blob/main/changelog_unreleased/TEMPLATE.md
Member
|
Is it possible to test here? https://github.com/prettier/prettier/tree/main/tests/dts |
Contributor
Author
|
prettier/tests/dts/unit/cases/plugins.ts Lines 4 to 7 in 24dfe5a |
Member
|
As I tested, if I remove added $ yarn jest tests/dts
DeprecationWarning: 'originalKeywordKind' has been deprecated since v5.0.0 and will no longer be usable after v5.2.0. Use 'identifierToKeywordKind(identifier)' instead.
FAIL tests/dts/unit/run.js
● Test suite failed to run
Error [ERR_WORKER_OUT_OF_MEMORY]: Worker terminated due to reaching memory limit: JS heap out of memory
Test Suites: 1 failed, 1 total
Tests: 0 total
Snapshots: 0 total
Time: 94.418 s
Ran all test suites matching /tests\/dts/i. |
Contributor
Author
|
This seems related: #15034 (comment) Very weird... |
fisker
approved these changes
Jul 18, 2023
sosukesuzuki
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #15034
TS Playground
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨