Revert "Enforce Single Attribute Per Line (#5501)"#11906
Closed
sosukesuzuki wants to merge 1 commit intomainfrom
Closed
Revert "Enforce Single Attribute Per Line (#5501)"#11906sosukesuzuki wants to merge 1 commit intomainfrom
sosukesuzuki wants to merge 1 commit intomainfrom
Conversation
This reverts commit 0e42acb.
4 tasks
Member
|
Yep, let's do it, missed that we are preparing a new release Another idea - do 2.7 release, there are only one feature |
Contributor
Author
2.7? Isn't it 2.6? |
Member
|
Oh, yes, 2.6 👍 |
Member
|
I don't know, these kind of reverts are annoying, we should figure a better way to do path release. |
Collaborator
|
Isn't it possible to create a branch from the 2.5 tag, and just cherry-pick the relevant commits? |
Contributor
Author
It is possible, but I didn't like it because it requires more git operations. However, I agree using revert is also annoying, so I think I will use cherry-pick this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6644
I don't disagree to this option. This option will be included in 2.6
I'm going to release 2.5.1 soon. And this option cannot be included in the patch version because it is a new feature.
So reverts #6644 for now.
We will revert this revert when we get closer to the 2.6 release.
/cc @alexander-akait