Skip to content

Properly format Sass module configuration values#11516

Open
niksy wants to merge 1 commit intoprettier:mainfrom
niksy:sass-with-print-width
Open

Properly format Sass module configuration values#11516
niksy wants to merge 1 commit intoprettier:mainfrom
niksy:sass-with-print-width

Conversation

@niksy
Copy link
Contributor

@niksy niksy commented Sep 13, 2021

Description

Mentioned in #11487 (comment).

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@niksy niksy force-pushed the sass-with-print-width branch from 5b41166 to 23d4faa Compare September 13, 2021 07:51
$black: #222,
$border-radius: 0.1rem,
$font-family:
"Helvetica, sans-serif",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm , I think it should on the same line...

Copy link
Contributor Author

@niksy niksy Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s whole string so it’s placed in new line when line width is 40 characters or less. Try playing with print width.

@niksy niksy mentioned this pull request Nov 28, 2021
1 task
@fisker fisker requested a review from alexander-akait July 19, 2022 09:16
@fisker
Copy link
Member

fisker commented Jul 19, 2022

@niksy Can you fix conflicts?

@niksy niksy force-pushed the sass-with-print-width branch from 3cee521 to c44be1a Compare July 25, 2022 14:44
@niksy
Copy link
Contributor Author

niksy commented Jul 25, 2022

@fisker done!

@fisker
Copy link
Member

fisker commented Aug 1, 2022

@alexander-akait Are you fine with this change?

@niksy niksy force-pushed the sass-with-print-width branch from c44be1a to c602c02 Compare August 1, 2022 07:21
@niksy niksy force-pushed the sass-with-print-width branch from c602c02 to 6e7530c Compare August 2, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants