Skip to content

Fix ESLint config #15944

@fisker

Description

@fisker

Due to ESLint ignore behavior change, we can't correctly lint files in tests/format/ except jsfmt.spec.js. eslint/eslint#17964 (comment)

We need update

tests/format/**/*.*
!tests/format/**/jsfmt.spec.js

to

# Ignore directories and files in `tests/format`
tests/format/**/*
# Unignore directories and `jsfmt.spec.js` file
!tests/format/**/
!tests/format/**/jsfmt.spec.js

To verify it works as expected,

  • Update tests/format/flow-repo/esproposal_class_instance_fields.warn/jsfmt.spec.js to use run_spec(__dirname, ["flow"])
  • Run yarn eslint tests/format/flow-repo/esproposal_class_instance_fields.warn/, should report error for jsfmt.spec.js but not other files.

Metadata

Metadata

Assignees

No one assigned

    Labels

    locked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.type:infraIssues about CI, publishing to npm, or similar

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions