-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Closed
Labels
locked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.Please open a new issue and fill out the template instead of commenting.type:infraIssues about CI, publishing to npm, or similarIssues about CI, publishing to npm, or similar
Description
Due to ESLint ignore behavior change, we can't correctly lint files in tests/format/ except jsfmt.spec.js. eslint/eslint#17964 (comment)
We need update
Lines 4 to 5 in 6c6a332
| tests/format/**/*.* | |
| !tests/format/**/jsfmt.spec.js |
to
# Ignore directories and files in `tests/format`
tests/format/**/*
# Unignore directories and `jsfmt.spec.js` file
!tests/format/**/
!tests/format/**/jsfmt.spec.js
To verify it works as expected,
- Update
tests/format/flow-repo/esproposal_class_instance_fields.warn/jsfmt.spec.jsto userun_spec(__dirname, ["flow"]) - Run
yarn eslint tests/format/flow-repo/esproposal_class_instance_fields.warn/, should report error forjsfmt.spec.jsbut not other files.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
locked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.Please open a new issue and fill out the template instead of commenting.type:infraIssues about CI, publishing to npm, or similarIssues about CI, publishing to npm, or similar