Skip to content

Add jackson-annotations dependency and use @JsonIgnore in Slice class#4

Merged
tdcmeehan merged 1 commit into
prestodb:masterfrom
imsayari404:slice_jackson
May 14, 2026
Merged

Add jackson-annotations dependency and use @JsonIgnore in Slice class#4
tdcmeehan merged 1 commit into
prestodb:masterfrom
imsayari404:slice_jackson

Conversation

@imsayari404

Copy link
Copy Markdown

Problem

When upgrading Presto to Jackson 2.18.6, tests fail with infinite recursion error:

com.fasterxml.jackson.databind.JsonMappingException:
Document nesting depth (1001) exceeds the maximum allowed (1000)
(through reference chain: ...->io.airlift.slice.Slice["output"]
->io.airlift.slice.BasicSliceOutput["underlyingSlice"]
->io.airlift.slice.Slice["output"]->...)

Added @JsonIgnore annotation to exclude getOutput() from JSON serialization

@sourcery-ai

sourcery-ai Bot commented Apr 22, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds Jackson annotations as an optional dependency and uses @JsonIgnore on Slice.getOutput() to prevent infinite Jackson serialization recursion when upgrading to Jackson 2.18.6.

Class diagram for Slice.getOutput() with JsonIgnore annotation

classDiagram
    class Slice {
        +BasicSliceInput getInput()
        <<JsonIgnore>> +SliceOutput getOutput()
    }

    class SliceOutput {
    }

    class BasicSliceOutput {
        -Slice underlyingSlice
        +BasicSliceOutput(Slice slice)
    }

    SliceOutput <|-- BasicSliceOutput
    Slice o-- BasicSliceOutput
Loading

File-Level Changes

Change Details Files
Add Jackson annotations dependency to support usage of @JsonIgnore.
  • Introduce com.fasterxml.jackson.core:jackson-annotations as an optional Maven dependency with version 2.18.6.
pom.xml
Prevent infinite Jackson serialization recursion for Slice by excluding getOutput() from JSON serialization.
  • Annotate Slice.getOutput() with @JsonIgnore to avoid serializing the cyclic Slice/BasicSliceOutput relationship when using Jackson 2.18.6.
src/main/java/com/facebook/slice/Slice.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Instead of hard-coding the jackson-annotations version in this module, consider wiring it through the same Jackson version property or BOM used elsewhere in the project so upgrades stay consistent and centralized.
  • Adding @JsonIgnore changes the JSON shape of Slice; if any custom serializers or deserializers rely on getOutput(), it may be safer to handle the recursion via a dedicated Jackson mixin or custom serializer to avoid coupling core code to Jackson-specific annotations.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Instead of hard-coding the jackson-annotations version in this module, consider wiring it through the same Jackson version property or BOM used elsewhere in the project so upgrades stay consistent and centralized.
- Adding @JsonIgnore changes the JSON shape of Slice; if any custom serializers or deserializers rely on getOutput(), it may be safer to handle the recursion via a dedicated Jackson mixin or custom serializer to avoid coupling core code to Jackson-specific annotations.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tdcmeehan tdcmeehan merged commit d008e07 into prestodb:master May 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants