Add jackson-annotations dependency and use @JsonIgnore in Slice class#4
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds Jackson annotations as an optional dependency and uses @JsonIgnore on Slice.getOutput() to prevent infinite Jackson serialization recursion when upgrading to Jackson 2.18.6. Class diagram for Slice.getOutput() with JsonIgnore annotationclassDiagram
class Slice {
+BasicSliceInput getInput()
<<JsonIgnore>> +SliceOutput getOutput()
}
class SliceOutput {
}
class BasicSliceOutput {
-Slice underlyingSlice
+BasicSliceOutput(Slice slice)
}
SliceOutput <|-- BasicSliceOutput
Slice o-- BasicSliceOutput
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Instead of hard-coding the jackson-annotations version in this module, consider wiring it through the same Jackson version property or BOM used elsewhere in the project so upgrades stay consistent and centralized.
- Adding @JsonIgnore changes the JSON shape of Slice; if any custom serializers or deserializers rely on getOutput(), it may be safer to handle the recursion via a dedicated Jackson mixin or custom serializer to avoid coupling core code to Jackson-specific annotations.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of hard-coding the jackson-annotations version in this module, consider wiring it through the same Jackson version property or BOM used elsewhere in the project so upgrades stay consistent and centralized.
- Adding @JsonIgnore changes the JSON shape of Slice; if any custom serializers or deserializers rely on getOutput(), it may be safer to handle the recursion via a dedicated Jackson mixin or custom serializer to avoid coupling core code to Jackson-specific annotations.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
7 tasks
aaneja
approved these changes
May 14, 2026
tdcmeehan
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When upgrading Presto to Jackson 2.18.6, tests fail with infinite recursion error:
Added @JsonIgnore annotation to exclude getOutput() from JSON serialization