Skip to content

chore(deps): Upgrade jest-environment-jsdom to version 30.3.0#27658

Closed
imsayari404 wants to merge 1 commit into
prestodb:masterfrom
imsayari404:jsdom
Closed

chore(deps): Upgrade jest-environment-jsdom to version 30.3.0#27658
imsayari404 wants to merge 1 commit into
prestodb:masterfrom
imsayari404:jsdom

Conversation

@imsayari404

@imsayari404 imsayari404 commented Apr 24, 2026 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Upgraded jest-environment-jsdom:29.7.0 to jest-environment-jsdom:30.3.0

Motivation and Context

Using a more recent version helps avoid potential vulnerabilities and ensures we aren't relying on outdated or unsupported code.

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==


## Summary by Sourcery

Build:
- Bump jest-environment-jsdom from 29.7.0 to 30.3.0 in presto-ui package.json and lockfile.

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Apr 24, 2026
@sourcery-ai

sourcery-ai Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the presto-ui test environment by bumping the jest-environment-jsdom dev dependency from 29.7.x to 30.3.x and refreshing yarn.lock to match, keeping Jest itself at 29.7.x.

File-Level Changes

Change Details Files
Upgrade jest-environment-jsdom dev dependency and sync lockfile for presto-ui tests.
  • Bump jest-environment-jsdom version range from ^29.7.0 to ^30.3.0 in the presto-ui package manifest devDependencies.
  • Regenerate or update yarn.lock entries so they are consistent with jest-environment-jsdom 30.3.0 and its transitive dependencies.
 presto-ui/src/package.json
presto-ui/src/yarn.lock
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@imsayari404 imsayari404 mentioned this pull request May 6, 2026
Merged
7 tasks
@imsayari404 imsayari404 marked this pull request as ready for review May 6, 2026 11:08
@imsayari404 imsayari404 requested review from a team and yhwang as code owners May 6, 2026 11:08
@prestodb-ci prestodb-ci requested review from a team, Shreya-ibm and faizdani-ibm and removed request for a team May 6, 2026 11:08
sourcery-ai[bot]
sourcery-ai Bot reviewed May 6, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents 
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="presto-ui/src/package.json" line_range="37" />
<code_context>
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
-    "jest-environment-jsdom": "^29.7.0",
+    "jest-environment-jsdom": "^30.3.0",
     "jquery": "3.7.1",
     "prettier": "^3.6.2",
</code_context>
<issue_to_address>
**issue (bug_risk):** Check compatibility between Jest 29.x and jest-environment-jsdom 30.x to avoid subtle runtime issues.

This upgrades `jest-environment-jsdom` to 30.x while Jest stays on 29.x. Since Jest environments are normally major-version aligned, this mismatch can cause subtle test/runtime issues. Please either bump Jest to 30.x as well or keep `jest-environment-jsdom` on a 29.x-compatible version.
</issue_to_address>
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread presto-ui/src/package.json
"identity-obj-proxy": "^3.0.0",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
"jest-environment-jsdom": "^30.3.0",

@sourcery-ai sourcery-ai Bot May 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Check compatibility between Jest 29.x and jest-environment-jsdom 30.x to avoid subtle runtime issues.

This upgrades jest-environment-jsdom to 30.x while Jest stays on 29.x. Since Jest environments are normally major-version aligned, this mismatch can cause subtle test/runtime issues. Please either bump Jest to 30.x as well or keep jest-environment-jsdom on a 29.x-compatible version.

@imsayari404 imsayari404 closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@yhwang yhwang Awaiting requested review from yhwang yhwang is a code owner

@faizdani-ibm faizdani-ibm Awaiting requested review from faizdani-ibm faizdani-ibm was automatically assigned from prestodb/ibm-reviewers

@Shreya-ibm Shreya-ibm Awaiting requested review from Shreya-ibm Shreya-ibm was automatically assigned from prestodb/ibm-reviewers

Assignees

No one assigned

Labels

from:IBM PR from IBM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imsayari404 @prestodb-ci