Reviewer's Guide

Changes the Presto runtime metric conversion to treat the metric count as an unsigned value and safely cast it when building a RuntimeMetric, preventing overflow issues.

Class diagram for updated metric count handling

classDiagram
  class Metric {
    <<struct>>
    RuntimeUnit unit
    int64_t sum
    uint64_t count
    int64_t max
    int64_t min
  }

  class RuntimeMetric {
    <<struct>>
    RuntimeUnit unit
    int64_t sum
    int64_t count
    int64_t max
    int64_t min
  }

  class PrestoTask {
    +protocol_RuntimeMetric toRuntimeMetric(string name, Metric metric)
  }

  class RuntimeMetricsUtils {
    +int64_t saturateCast(uint64_t value)
    +protocol_RuntimeUnit toPrestoRuntimeUnit(RuntimeUnit unit)
  }

  PrestoTask --> Metric : uses
  PrestoTask --> RuntimeMetric : builds
  PrestoTask ..> RuntimeMetricsUtils : calls
  Metric --> RuntimeMetric : converted_via_toRuntimeMetric
  RuntimeMetricsUtils <.. RuntimeMetric : safe_cast_for_count

Flow diagram for safe casting of metric count to RuntimeMetric

flowchart LR
  A["Metric.count (uint64_t)"] --> B["saturateCast(count)"]
  B --> C["RuntimeMetric.count (int64_t)"]

File-Level Changes

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.