DNM: Upgrade iceberg to 1.10 version#26754
Closed
pratyakshsharma wants to merge 1 commit into
Closed
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgrades the Iceberg dependency used by the Presto Iceberg module from 1.8.1 to 1.10.0 and updates test code to use the new Parquet writer factory method required by the upgraded Iceberg version. Sequence diagram for updated Parquet writer creation in Iceberg testssequenceDiagram
actor Developer
participant IcebergDistributedTestBase
participant IcebergParquetWriterFactory
participant IcebergParquetWriter
Developer->>IcebergDistributedTestBase: runDistributedIcebergTest()
IcebergDistributedTestBase->>IcebergParquetWriterFactory: createWriter(schema, outputFile, properties)
IcebergParquetWriterFactory->>IcebergParquetWriter: newWriter(schema, outputFile, properties)
IcebergParquetWriter-->>IcebergParquetWriterFactory: writerInstance
IcebergParquetWriterFactory-->>IcebergDistributedTestBase: writerInstance
IcebergDistributedTestBase->>IcebergParquetWriter: writeTestData(records)
IcebergParquetWriter-->>IcebergDistributedTestBase: writeComplete
Class diagram for updated Iceberg Parquet writer factory usage in testsclassDiagram
class IcebergDistributedTestBase {
+runDistributedIcebergTest()
+createTestTable(tableName)
+writeParquetData(schema, outputFile, properties)
}
class IcebergParquetWriterFactory {
+createWriter(schema, outputFile, properties) : IcebergParquetWriter
}
class IcebergParquetWriter {
+newWriter(schema, outputFile, properties) : IcebergParquetWriter
+write(records)
+close()
}
IcebergDistributedTestBase --> IcebergParquetWriterFactory : uses
IcebergParquetWriterFactory --> IcebergParquetWriter : creates
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
7 tasks
Member
|
Closing this PR in favor of #26879. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: