Skip to content

DNM: Upgrade iceberg to 1.10 version#26754

Closed
pratyakshsharma wants to merge 1 commit into
prestodb:masterfrom
pratyakshsharma:iceberg-upgrade-1.10
Closed

DNM: Upgrade iceberg to 1.10 version#26754
pratyakshsharma wants to merge 1 commit into
prestodb:masterfrom
pratyakshsharma:iceberg-upgrade-1.10

Conversation

@pratyakshsharma

Copy link
Copy Markdown
Contributor

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Dec 9, 2025
@prestodb-ci prestodb-ci requested review from a team, Joe-Abraham and namya28 and removed request for a team December 9, 2025 15:20
@sourcery-ai

sourcery-ai Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Upgrades the Iceberg dependency used by the Presto Iceberg module from 1.8.1 to 1.10.0 and updates test code to use the new Parquet writer factory method required by the upgraded Iceberg version.

Sequence diagram for updated Parquet writer creation in Iceberg tests

sequenceDiagram
    actor Developer
    participant IcebergDistributedTestBase
    participant IcebergParquetWriterFactory
    participant IcebergParquetWriter

    Developer->>IcebergDistributedTestBase: runDistributedIcebergTest()
    IcebergDistributedTestBase->>IcebergParquetWriterFactory: createWriter(schema, outputFile, properties)
    IcebergParquetWriterFactory->>IcebergParquetWriter: newWriter(schema, outputFile, properties)
    IcebergParquetWriter-->>IcebergParquetWriterFactory: writerInstance
    IcebergParquetWriterFactory-->>IcebergDistributedTestBase: writerInstance
    IcebergDistributedTestBase->>IcebergParquetWriter: writeTestData(records)
    IcebergParquetWriter-->>IcebergDistributedTestBase: writeComplete
Loading

Class diagram for updated Iceberg Parquet writer factory usage in tests

classDiagram
    class IcebergDistributedTestBase {
        +runDistributedIcebergTest()
        +createTestTable(tableName)
        +writeParquetData(schema, outputFile, properties)
    }

    class IcebergParquetWriterFactory {
        +createWriter(schema, outputFile, properties) : IcebergParquetWriter
    }

    class IcebergParquetWriter {
        +newWriter(schema, outputFile, properties) : IcebergParquetWriter
        +write(records)
        +close()
    }

    IcebergDistributedTestBase --> IcebergParquetWriterFactory : uses
    IcebergParquetWriterFactory --> IcebergParquetWriter : creates
Loading

File-Level Changes

Change Details Files
Update Iceberg library version used by the Presto Iceberg module.
  • Change the dep.iceberg.version Maven property from 1.8.1 to 1.10.0 in the presto-iceberg module POM.
  • Keep other dependency versions and build properties unchanged.
presto-iceberg/pom.xml
Align Parquet delete writer creation with the new Iceberg 1.10 Parquet API.
  • Replace GenericParquetWriter::buildWriter with GenericParquetWriter::create when constructing position delete Parquet writers in IcebergDistributedTestBase.
  • Replace GenericParquetWriter::buildWriter with GenericParquetWriter::create when constructing equality delete Parquet writers in IcebergDistributedTestBase.
  • Preserve existing test logic for writing delete files, including schema handling and equality field IDs.
presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hantangwangd

Copy link
Copy Markdown
Member

Closing this PR in favor of #26879.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants