Skip to content

fix: Disable always active spark2 profile#26514

Closed
aaneja wants to merge 1 commit into
prestodb:masterfrom
aaneja:fixProfile
Closed

fix: Disable always active spark2 profile#26514
aaneja wants to merge 1 commit into
prestodb:masterfrom
aaneja:fixProfile

Conversation

@aaneja

@aaneja aaneja commented Nov 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Make the spark2 profile inactive by default

Motivation and Context

#26465

Impact

CI will run maven enforcer checks which were accidentally disabled

Test Plan

Ran ./mvnw help:active-profiles and manually confirmed that spark2 is inactive

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release notes

== NO RELEASE NOTE ==

@aaneja aaneja requested a review from a team as a code owner November 3, 2025 11:19
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Nov 3, 2025
@prestodb-ci prestodb-ci requested review from a team, auden-woolfson and pratyakshsharma and removed request for a team November 3, 2025 11:19
@shrinidhijoshi

shrinidhijoshi commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator

@aaneja Disabling this effectively makes the presto project unbuildable as there would be unsatisfied dependencies for the presto-spark* modules.

If the main goal is to re-enable the maven enforcer checks that were inadvertantly disabled in this PR #25552, let's work on just re-enabling those checks on the spark2 profile. The original author of the PR Kewen will be working on this.

@aaneja aaneja mentioned this pull request Nov 5, 2025
Merged
6 tasks
@aaneja

aaneja commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The original author of the PR Kewen will be working on this.

Awesome ! Tagging @wangkewen for visibility

Please also fix modules currently failing enforcer, e.g this one - #26019 (comment)

@aaneja

aaneja commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

@shrinidhijoshi Did you try running the Presto build with the spark2 or spark3 profile explicitly set ? (-Pspark2 e.g) The build should work then IMO

@aaneja aaneja closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pratyakshsharma pratyakshsharma Awaiting requested review from pratyakshsharma pratyakshsharma was automatically assigned from prestodb/ibm-reviewers

@auden-woolfson auden-woolfson Awaiting requested review from auden-woolfson auden-woolfson was automatically assigned from prestodb/ibm-reviewers

@ghelmling ghelmling Awaiting requested review from ghelmling

@shrinidhijoshi shrinidhijoshi Awaiting requested review from shrinidhijoshi

Assignees

No one assigned

Labels

from:IBM PR from IBM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aaneja @shrinidhijoshi @prestodb-ci