[pos][native] Use okhttp instead of airlift.http in pos native#25797
Merged
shrinidhijoshi merged 1 commit intoAug 18, 2025
Merged
Conversation
ea5165f to
2090bc2
Compare
rschlussel
previously approved these changes
Aug 15, 2025
1a7a956 to
f4af2e8
Compare
f4af2e8 to
c77a112
Compare
rschlussel
reviewed
Aug 17, 2025
| } | ||
|
|
||
| @Test | ||
| @Ignore |
Contributor
There was a problem hiding this comment.
why did you disable this test? Add ac comment and link to an issue. Also, use @Test(enabled=false) instead of @ignore
Collaborator
Author
There was a problem hiding this comment.
Created a github issue with details and updated disablement
d0d2620 to
a77ed8d
Compare
Collaborator
Author
|
@rschlussel Addressed comments. Please check. Thanks! |
rschlussel
approved these changes
Aug 18, 2025
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the Jetty upgrade, we can no longer run presto-on-spark native on JDK8/11. This is because presto-on-spark (pos) native relies on airlift.http-client to communicate between the JVM code and the Cpp sidecar.
But, with jetty upgrade, min JDK version is 17.
This PR replaces the jetty http client with okhttp in the presto-on-spark native codepath.
To do this it does 2 things
Below are exhaustive list of changes to achieve this
OkHttpResponseHandler,OkHttpBaseResponse, (dto)OkHttpHeaderName.com.facebook.presto.spark.execution.httpwhich relied on http client metadata classes (headers, http status , header string constants) with either okhttp alternatives where available, or google/apache commons libs where okhttp alternative is not available.Remove drift dependency
PagesResponseHandler.This enables deletion/cleanup of the
HttpRpcShuffleClientHttpAndThriftRpcShuffleClientProvider,HttpShuffleClientProviderThriftRpcShuffleClientThriftShuffleClientProviderFinally we have also updated the pom Remove pom dependency on
http-client,http-server,drift-client,drift-transport-apiTest Plan
CI tests