Skip to content

[Native] Register text writer#25673

Merged
kewang1024 merged 1 commit into
prestodb:masterfrom
kewang1024:add-text-writer2
Aug 6, 2025
Merged

[Native] Register text writer#25673
kewang1024 merged 1 commit into
prestodb:masterfrom
kewang1024:add-text-writer2

Conversation

@kewang1024

@kewang1024 kewang1024 commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator
== NO RELEASE NOTES ==

@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Aug 1, 2025
@kewang1024 kewang1024 marked this pull request as ready for review August 1, 2025 23:54
@kewang1024 kewang1024 requested a review from a team as a code owner August 1, 2025 23:54
@kewang1024 kewang1024 requested a review from zacw7 August 1, 2025 23:54
@kewang1024 kewang1024 force-pushed the add-text-writer2 branch 5 times, most recently from fefb809 to 95239bf Compare August 4, 2025 06:50
Comment thread presto-native-execution/presto_cpp/main/PrestoServer.cpp
zacw7
zacw7 previously approved these changes Aug 5, 2025
tanjialiang
tanjialiang previously approved these changes Aug 5, 2025

@tanjialiang tanjialiang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM % minor naming issue.

Comment thread presto-native-execution/presto_cpp/main/common/Configs.h Outdated
@kewang1024 kewang1024 dismissed stale reviews from tanjialiang and zacw7 via 839285f August 6, 2025 00:15
@kewang1024 kewang1024 merged commit 93c482f into prestodb:master Aug 6, 2025
171 of 172 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants