feat: Add initial spatial join support in Prestissimo using a nested loop join#25583
feat: Add initial spatial join support in Prestissimo using a nested loop join#25583wraymo wants to merge 1 commit into
Conversation
aditi-pandit
left a comment
There was a problem hiding this comment.
@wraymo : Thanks for this code. Would it be possible to add few e2e tests in https://github.com/prestodb/presto/tree/master/presto-native-tests/src/test/java/com/facebook/presto/nativetests for simple geo/geo-spatial queries.
With reasonable tests I should be able to approve this PR.
There was a problem hiding this comment.
Just wanted to confirm that you generated this using make presto_protocol command
https://github.com/prestodb/presto/tree/master/presto-native-execution/presto_cpp/presto_protocol#presto-native-worker-protocol-code-generation
There was a problem hiding this comment.
You will need some code in core::PlanNodePtr VeloxQueryPlanConverterBase::toVeloxQueryPlan function as well https://github.com/prestodb/presto/blob/master/presto-native-execution/presto_cpp/main/types/PrestoToVeloxQueryPlan.cpp#L1769
Description
This PR introduces basic support for spatial joins in Prestissimo by using the existing nested loop join mechanism. While this approach is simple and ensures correctness, it does not yet include any performance optimizations. It serves as a starting point for enabling spatial joins and will be improved in subsequent iterations.
Motivation and Context
Spatial joins are essential for many geospatial analytics use cases but are currently unsupported in Prestissimo.
Impact
Spatial join will be unlocked.
Test Plan
Verified correctness with Velox.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.