Skip to content

[WIP] Add native row expression optimizer#24238

Draft
tdcmeehan wants to merge 2 commits into
prestodb:masterfrom
tdcmeehan:expr-spi-native
Draft

[WIP] Add native row expression optimizer#24238
tdcmeehan wants to merge 2 commits into
prestodb:masterfrom
tdcmeehan:expr-spi-native

Conversation

@tdcmeehan

@tdcmeehan tdcmeehan commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

Description

Add a ExpressionOptimizer which delegates to the native sidecar process to evaluate expressions with Velox.

Depends on #24144

Motivation and Context

RFC-0006. See #24126 for larger changes that include the Presto sidecar as described in the RFC.

Impact

No impact by default as the old in-memory evaluation is the default.

Test Plan

Tests have been added.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Dec 10, 2024
@prestodb-ci prestodb-ci requested review from a team, anandamideShakyan and pratyakshsharma and removed request for a team December 10, 2024 21:49
@tdcmeehan tdcmeehan force-pushed the expr-spi-native branch 6 times, most recently from 95ca594 to 1e8db61 Compare December 12, 2024 20:29
@tdcmeehan tdcmeehan force-pushed the expr-spi-native branch 3 times, most recently from b27e716 to d016dbf Compare January 9, 2025 21:09
@tdcmeehan tdcmeehan force-pushed the expr-spi-native branch 3 times, most recently from bffa89f to 2afd46a Compare January 29, 2025 21:50
@pramodsatya pramodsatya mentioned this pull request Feb 2, 2025
Closed
@tdcmeehan tdcmeehan mentioned this pull request May 20, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pratyakshsharma pratyakshsharma Awaiting requested review from pratyakshsharma pratyakshsharma was automatically assigned from prestodb/ibm-reviewers

@anandamideShakyan anandamideShakyan Awaiting requested review from anandamideShakyan anandamideShakyan was automatically assigned from prestodb/ibm-reviewers

@shrinidhijoshi shrinidhijoshi Awaiting requested review from shrinidhijoshi shrinidhijoshi will be requested when the pull request is marked ready for review shrinidhijoshi is a code owner

@pdabre12 pdabre12 Awaiting requested review from pdabre12 pdabre12 will be requested when the pull request is marked ready for review pdabre12 is a code owner

@jaystarshot jaystarshot Awaiting requested review from jaystarshot jaystarshot will be requested when the pull request is marked ready for review jaystarshot is a code owner

@feilong-liu feilong-liu Awaiting requested review from feilong-liu feilong-liu will be requested when the pull request is marked ready for review feilong-liu is a code owner

@elharo elharo Awaiting requested review from elharo elharo will be requested when the pull request is marked ready for review elharo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

from:IBM PR from IBM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tdcmeehan @prestodb-ci @pramodsatya