remove joda-time#18035
Open
dutta-sh wants to merge 7 commits into
Open
Conversation
Contributor
|
@dutta-sh Can you please squash the commits |
ajaygeorge
reviewed
Jul 14, 2022
| public long getLong() | ||
| { | ||
| long millis = FORMATTER.parseMillis(getSlice().toStringAscii()); | ||
| TemporalAccessor temporal = FORMATTER.parseBest(getSlice().toStringAscii(), LocalDateTime::from, LocalDate::from); |
Contributor
There was a problem hiding this comment.
Can you help me understand why we need parseBest here.
Author
There was a problem hiding this comment.
String representing a date (with or without time) needs two separate formatters, or needs to use parseBest. More context here - https://stackoverflow.com/questions/48280447/java-8-datetimeformatter-with-optional-part
ajaygeorge
reviewed
Jul 15, 2022
ajaygeorge
reviewed
Jul 15, 2022
ajaygeorge
reviewed
Jul 15, 2022
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Java 8 java.time packages to replace joda-time