You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@tdcmeehan dumb question : It wasn't clear looking at the PR description why the order of heartbeats is important.
Say Node A sends heartbeats to Node B. Node A dies sometime and If Heartbeat 101 comes after Heartbeat 102, the worst case scenario is Node B thinks Node A is alive for a delta time it wasn't supposed to be alive because eventually Heartbeat 103 will not arrive. Is that the problem we are trying to solve.?
@tdcmeehan dumb question : It wasn't clear looking at the PR description why the order of heartbeats is important. Say Node A sends heartbeats to Node B. Node A dies sometime and If Heartbeat 101 comes after Heartbeat 102, the worst case scenario is Node B thinks Node A is alive for a delta time it wasn't supposed to be alive because eventually Heartbeat 103 will not arrive. Is that the problem we are trying to solve.?
The exact issue is there are certain scenarios where the state has changed and it's not desirable to to revert to a previous revision of the state. This also enables us to send heartbeats more aggressively, for example on state transitions, and to lower the interval for in between events such as queueing and running states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan - Unit tests